afonsofrancof/sdns-proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(measurement): only consecutive fails matter

Browse Source
This commit is contained in:
Afonso Franco
2025-09-08 23:50:41 +01:00
parent de619583ea
commit 81f204f933
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
internal/qol/measurement.go
View File

@@ -75,8 +75,8 @@ func (r *MeasurementRunner) runMeasurement(upstream string, domains []string, qT
// Setup output files // Setup output files
jsonPath, pcapPath := GenerateOutputPaths(r.config.OutputDir, upstream, r.config.DNSSEC) jsonPath, pcapPath := GenerateOutputPaths(r.config.OutputDir, upstream, r.config.DNSSEC)
fmt.Printf(">>> Measuring %s (dnssec=%v) → %s\n", upstream, r.config.DNSSEC, fmt.Printf(">>> Measuring %s (dnssec=%v) → %s\n", upstream, r.config.DNSSEC,
strings.TrimSuffix(strings.TrimSuffix(jsonPath, ".jsonl"), r.config.OutputDir+"/")) strings.TrimSuffix(strings.TrimSuffix(jsonPath, ".jsonl"), r.config.OutputDir+"/"))
// Setup packet capture // Setup packet capture
@@ -127,6 +127,8 @@ func (r *MeasurementRunner) runQueries(dnsClient client.DNSClient, upstream stri
if metric.ResponseCode == "ERROR" { if metric.ResponseCode == "ERROR" {
failureCount++ failureCount++
} else if metric.ResponseCode == "NOERROR" {
failureCount = 0
} }
if err := writer.WriteMetric(metric); err != nil { if err := writer.WriteMetric(metric); err != nil {
@@ -222,8 +224,8 @@ func (r *MeasurementRunner) readDomainsFile() ([]string, error) {
func (r *MeasurementRunner) checkCapturePermissions() error { func (r *MeasurementRunner) checkCapturePermissions() error {
handle, err := pcap.OpenLive("any", 65535, false, time.Millisecond*100) handle, err := pcap.OpenLive("any", 65535, false, time.Millisecond*100)
if err != nil { if err != nil {
if strings.Contains(err.Error(), "permission") || if strings.Contains(err.Error(), "permission") ||
strings.Contains(err.Error(), "Operation not permitted") { strings.Contains(err.Error(), "Operation not permitted") {
return fmt.Errorf("insufficient permissions for packet capture") return fmt.Errorf("insufficient permissions for packet capture")
} }
return nil return nil